Помогите починить программу c/c++

[volk00]

#include<iostream>
#include<cstdio>
#include<cstdlib>
#include<time.h>
#include<windows.h>
#include<conio.h>
#include<string.h>
using namespace std;
void gmindstr(char* a,char* b,char* c,char* d,char* z,char* y,char* x,char* w);
int main()
{
    char mnch='Y';
    int swh;
    while((mnch=='Y')||(mnch=='y'))
    {
        system("CLS");
        cout<<"Mastermind the game" << endl;
        cout<<"Press the Enter Key to continue" <<endl;
        getchar();
        cout<<"Please Choose an Option:" <<endl;
        cout<<"(1).Start Game" <<endl;
        cout<<"(2).Help" <<endl;
        cout<<"(3).Quit" <<endl;
        cout<<"Number Selection -> ";
        cin>>swh;
        switch(swh)
        {
        case 1:gmindstr("","","","","","","","");
                    cout<<"Do you wish to go back to the main menu? " << endl;
                    cout<<"Yes(Y) or No(N)" << endl;
                    cin>>mnch;
                    break;
            case 2:system("CLS");
                    cout<<"Rules and help" <<endl;
                    cout<<"Once you start the game, computer generates 4 colors, they can be Green, Blue, Red, Yellow, Orange, Purple. And you have 8 tries to guess which number and in what order. By Aleksandrs Volkovs, Group 2. " <<endl;
                    cout<<"Do you wish to go back to the main menu?" << endl;
                    cout<<"Yes(Y) or No(N)" << endl;
                    cin>>mnch;
                    break;
            case 3:mnch='N';
                    cout<<"Goodbye." << endl;
                    break;
            default:mnch='N';
                    cout<<"Goodbye." << endl;
                    break;
        }
    }
    system("CLS"); // clear screen
    cout<<"Thank you for playing";
    getchar(); // get input
    return 0;
}

char* number_to_color(int n)
{
    char* charout;
    if (n<=1)
    { // if n is less than or equal to 1 ie 0 or 1 set to green (g)
    charout = "g";
        return charout;
    }
    else if (n<=2)
    {
    charout = "b";
        return charout;
    }
    else if (n<=4)
    {
    charout = "r";
        return charout;
    }
    else if (n<=7)
    {
    charout = "y";
        return charout;
    }
    else if (n<=8)
    {
    charout = "o";
        return charout;
    }
    else {
    charout = "p";
        return charout;
    }
}

void gmindstr(char *a = "", char *b = "", char *c = "", char *d = "", char *z = "", char *y = "", char *x = "", char *w = "")
    {
    time_t srand(time(NULL)); // generate random numbers from time from the current unix timestamp
    char final='Y';
    while((final=='Y')||(final=='y'))
    {   system("CLS");
        cout<<"Welcome to Mastermind";
        cout<<"I have chosen 4 colors out of the colors: (g)reen, (b)lue, (r)ed, (y)ellow, (o)range, (p)urple!";
        cout<<"\n\nGuess which colors I have before your turns (8 left) runs out!";
        int test=1,hint=0;

        // This is where the cpu guesses random colors to select as the puzzle
        char *z=number_to_color(rand()%10);
        char *y=number_to_color(rand()%10);
        char *x=number_to_color(rand()%10);
        char *w=number_to_color(rand()%10);

        // loop over the guesses (the user gets 8)
        for(int n=1;n<=8;n++)
        {
            cout<<"Enter your color guess combination" << endl;
            cout<<"Separate each color letter with space! (single letters only!)" << endl;
            cout<<"Colors: (g)reen, (b)lue, (r)ed, (y)ellow, (o)range, (p)urple!" << endl;

            // Wait for user input then put their guess into the guess vars
            cin>>*a>>*b>>*c>>*d;

            // Now we have their guess proceed with checking if they won already
            if((*a==*z)&&(*b==*y)&&(*c==*x)&&(*d==*w)) {
                cout<<"YOU WIN!" << endl;
            }
            else
            {
                if(n==8) {
                    cout<<"You lose!" << endl;
                    cout<<"Correct answer was "<<z<<" "<<y<<" "<<x<<" "<<w<<" !!!" << endl;
                } else {
                    // Logic Goes Here
                    // You got x colors of x colors right

                    cout<<"\n\nYou can try again, "<<8-n<<" turns left";
                }
            }
        }
        cout<<"\n\n\nDo you want to try again?";
        cout<<"\n Yes(Y) or No(N)> ";
        cin>>final;
        system("CLS"); // clear screen
    }

}

[volk00]

помогите пожалуйста

[Stilet]

А что в ней сломалось?

[volk00]

Сообщение от Stilet

А что в ней сломалось?

не уверен, после запуска ломается

[Stilet]

после запуска ломается

Это не говорит ни о чем. Конкретнее.

[volk00]

Сообщение от Stilet

Это не говорит ни о чем. Конкретнее.

[volk00]

http://imgur.com/UJ1msed

[Smogg]

#include<string.h>
....
   // Wait for user input then put their guess into the guess vars
   cin>>*a>>*b>>*c>>*d; 
...

попробуй все таки использовать string'и. Будет гораздо меньше проблем с обращениями к памяти.

[volk00]

Сообщение от Smogg

#include<string.h>
....
   // Wait for user input then put their guess into the guess vars
   cin>>*a>>*b>>*c>>*d; 
...

попробуй все таки использовать string'и. Будет гораздо меньше проблем с обращениями к памяти.

как это можно сделать? никогда не использовал их
это моя вторая программа

[Smitt&Wesson]

Сообщение от volk00

как это можно сделать? никогда не использовал их
это моя вторая программа

А первая, сломалась - напрочь?